Add OPC-UA read-only adapter foundation#226
Merged
Merged
Conversation
smithaldon1
commented
May 25, 2026
Member
Author
smithaldon1
left a comment
There was a problem hiding this comment.
Reviewed and approved for merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211
Summary
ProtocolConnectionProfilerecords from the local profile store.profile.opcua.node_idsthrough an injectable node reader; no browse, write, or arbitrary tag discovery path is added.process.measurement.recordedFactoryEvents with source metadata for connection profile ID, node ID, adapter name, and poll index.Test Evidence
.venv/bin/python -m pytest services/ingestion/tests/test_opcua_read_only_adapter.py- passed, 7 tests.make test-integration- passed, 74 tests.make lint- passed, Ruff found no issues after import formatting.make typecheck- passed,compileallcompleted acrosspackagesandservices.make test- passed, 246 tests.make docs- passed; docs are Markdown-only and no checker is configured yet.git diff --checkandgit diff --cached --check- passed.Docs Impact
services/ingestion/README.mdwith the OPC-UA read-only adapter foundation, source metadata behavior, safety boundary, and focused test command.docs/LEARNING_LOG.mdwith what changed, why it matters, how the data flows, how to test it, and the next learning step.Follow-up Work
mapping_referencesupplies site, line, asset, unit, and signal metadata instead of adapter defaults.