Skip to content

fix(windows): 归一 QA hotkey 的跨平台修饰键语义#151

Merged
appergb merged 2 commits into
Open-Less:mainfrom
Cooper-X-Oak:codex/issue-148-qa-hotkey-normalization
May 2, 2026
Merged

fix(windows): 归一 QA hotkey 的跨平台修饰键语义#151
appergb merged 2 commits into
Open-Less:mainfrom
Cooper-X-Oak:codex/issue-148-qa-hotkey-normalization

Conversation

@Cooper-X-Oak
Copy link
Copy Markdown
Contributor

@Cooper-X-Oak Cooper-X-Oak commented May 1, 2026

摘要

Fixes #148

说明这个 PR 解决的单一目标:归一 QA hotkey 的跨平台 modifier 语义,避免 macOS cmd 偏好在 Windows runtime 中字面漂移成 Win 键。

问题层面 / Problem layer

  • 这是 跨平台配置语义层 / config normalization + migration 的修复。
  • 当前运行态错误主要在 Windows 暴露,但 PR 目标是修正共享配置模型,而不是只补一个 Windows 临时映射。

修复 / 新增 / 改进

兼容

  • 不包含:QA panel UI、ASR/LLM 请求链路、Windows 主窗口视觉问题
  • 对现有用户 / 本地环境 / 构建流程的影响:可能涉及历史 qaHotkey 配置迁移与默认值回显

测试计划

@Cooper-X-Oak Cooper-X-Oak marked this pull request as ready for review May 1, 2026 22:02
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Cooper-X-Oak, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a758cfa998

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +194 to +195
if matches!(tag.as_str(), "cmd" | "command") {
return "ctrl".to_string();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update Windows expectations for cmd alias behavior

On Windows targets this change remaps cmd/command to ctrl in parse_binding, but the existing parse_letter_binding unit test in the same file still asserts that cmd sets Modifiers::SUPER; that test will now fail whenever tests are run for target_os = "windows", creating a platform-specific red CI and hiding real regressions behind expected failures.

Useful? React with 👍 / 👎.

@appergb appergb merged commit c8bb089 into Open-Less:main May 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[windows] QA hotkey 跨平台配置未归一,cmd 语义漂移为 Win 键

2 participants