fix(windows): 归一 QA hotkey 的跨平台修饰键语义#151
Conversation
There was a problem hiding this comment.
Sorry @Cooper-X-Oak, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a758cfa998
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if matches!(tag.as_str(), "cmd" | "command") { | ||
| return "ctrl".to_string(); |
There was a problem hiding this comment.
Update Windows expectations for cmd alias behavior
On Windows targets this change remaps cmd/command to ctrl in parse_binding, but the existing parse_letter_binding unit test in the same file still asserts that cmd sets Modifiers::SUPER; that test will now fail whenever tests are run for target_os = "windows", creating a platform-specific red CI and hiding real regressions behind expected failures.
Useful? React with 👍 / 👎.
摘要
Fixes #148
说明这个 PR 解决的单一目标:归一 QA hotkey 的跨平台 modifier 语义,避免 macOS
cmd偏好在 Windows runtime 中字面漂移成Win键。问题层面 / Problem layer
修复 / 新增 / 改进
qa_hotkey.rs/ preference load or migration path / cross-platform validation兼容
qaHotkey配置迁移与默认值回显测试计划
cmd语义静默注册为Winhotkeyopenless.log