Skip to content

fix(qa): QA recorder error monitor (closes #168) #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
appergb merged 1 commit into from
May 2, 2026
Merged

fix(qa): QA recorder error monitor (closes #168) #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion openless-all/app/src-tauri/src/coordinator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,6 +1039,33 @@ fn spawn_recorder_error_monitor(inner: &Arc<Inner>, rx: mpsc::Receiver<RecorderE
.ok();
}

/// QA 录音 runtime error 监听器。镜像 `spawn_recorder_error_monitor` 的语义但走 QA
/// 收尾路径（`finish_qa_with_error` 替代 `abort_recording_with_error`）。
/// 用 qa_state.session_id 守卫 stale 事件。详见 issue #168。
fn spawn_qa_recorder_error_monitor(inner: &Arc<Inner>, rx: mpsc::Receiver<RecorderError>) {
let captured_session_id = inner.qa_state.lock().session_id;
let inner = Arc::clone(inner);
std::thread::Builder::new()
.name("openless-qa-recorder-error-monitor".into())
.spawn(move || {
if let Ok(err) = rx.recv() {
let current_session_id = inner.qa_state.lock().session_id;
if captured_session_id != current_session_id {
log::warn!(
"[coord] QA recorder error from stale session {} dropped (current={}, err={})",
captured_session_id,
current_session_id,
err
);
return;
}
log::error!("[coord] QA recorder runtime error: {err}");
finish_qa_with_error(&inner, format!("录音设备异常: {err}"));
}
Comment on lines +1062 to +1064
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Stop QA resources before marking runtime-error session idle

When a recorder runtime error occurs, this path immediately calls finish_qa_with_error, which only updates UI/state and sets qa_state.phase = Idle but does not take() and stop qa_recorder or cancel qa_asr. In this scenario, cancel_qa_session will no longer clean up because it early-returns on Idle, so the failed recorder/asr can remain alive and the old Recorder may be dropped without stop() (its own docs say drop does not stop), causing leaked audio threads and possible microphone/device contention on the next QA attempt.

Useful? React with 👍 / 👎.

})
.ok();
}

fn abort_recording_with_error(inner: &Arc<Inner>, message: String) {
let elapsed = {
let mut state = inner.state.lock();
Expand Down Expand Up @@ -1754,8 +1781,11 @@ async fn begin_qa_session(inner: &Arc<Inner>) -> Result<(), String> {
});

match Recorder::start(consumer, level_handler) {
Ok((rec, _runtime_errors)) => {
Ok((rec, runtime_errors)) => {
*inner.qa_recorder.lock() = Some(rec);
// QA 也跟主听写一样监听 cpal runtime error。设备中途消失 / panic 时
// 不能让 QA 永远卡在 Recording 没反馈。详见 issue #168。
spawn_qa_recorder_error_monitor(inner, runtime_errors);
}
Err(e) => {
log::error!("[coord] QA recorder start failed: {e}");
Expand Down
Loading