chore(repo): 统一项目目录命名#39
Merged
Merged
Conversation
The Tauri app lived under a path containing a literal space, which made CI paths and local commands easy to quote incorrectly. Rename the active tree to openless-all and update repository references so scripts, docs, and release workflows use the same space-free path. Constraint: Preserve the existing app layout and move only the containing directory name. Rejected: Add compatibility symlinks | would keep two app paths and leave quoting hazards in place. Confidence: high Scope-risk: moderate Tested: npm run build Tested: cargo clean && cargo check Tested: git diff --check Tested: grep -R for old openless -all and openless%20-all references
Reviewer's GuideStandardizes the active app directory name from Sequence diagram for Settings provider change using updatePrefssequenceDiagram
actor User
participant SettingsPage
participant ProvidersSection
participant PreferencesStore
participant Backend
User->>SettingsPage: change active ASR provider
SettingsPage->>ProvidersSection: onProviderSelected(id)
ProvidersSection->>PreferencesStore: setActiveAsrProvider(id)
PreferencesStore-->>ProvidersSection: active provider updated
ProvidersSection->>PreferencesStore: updatePrefs(nextPrefs)
PreferencesStore->>PreferencesStore: update in memory preferences
PreferencesStore->>Backend: persist preferences
Backend-->>PreferencesStore: persistence ok
PreferencesStore-->>ProvidersSection: prefs updated
ProvidersSection-->>SettingsPage: UI reflects new provider
Updated class diagram for Settings preferences update flowclassDiagram
class ProvidersSection {
+handleProviderChange(id)
}
class PreferencesStore {
+setActiveAsrProvider(id)
+updatePrefs(nextPrefs)
}
class Backend {
+persistPreferences(preferences)
}
ProvidersSection --> PreferencesStore : uses
PreferencesStore --> Backend : persists via
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
openless-all/README.mdthe GNU/MinGW section still says “contains a space inopenless-all”, which is no longer true after this rename—please update the wording to reflect the new no-space directory name and rationale.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `openless-all/README.md` the GNU/MinGW section still says “contains a space in `openless-all`”, which is no longer true after this rename—please update the wording to reflect the new no-space directory name and rationale.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The app directory was renamed to openless-all, but the GNU/MinGW route still described the new name as if it contained a space. Update the wording so the rationale matches the current path and keeps the helper-script guidance focused on consistent GNU setup. Constraint: Documentation-only code review follow-up. Confidence: high Scope-risk: narrow Tested: git diff --check
Collaborator
Author
|
@sourcery-ai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
Fixes #13。
本 PR 解决 Windows GNU/MinGW 构建受带空格目录影响的问题。
原仓库目录
openless -all/中包含空格，在 Windows 使用 Rust GNU toolchain 和 MinGW 构建时，可能导致dlltool/ assembler 在生成 import library 阶段失败。为避免该问题，本 PR 将项目目录统一改为无空格形式openless-all/，并同步更新工作流、文档和仓库内部引用。同时顺手修复当前远端基线中导致前端构建失败的
Settings.tsx旧调用问题，将其改为现有的updatePrefs。修复 / 新增 / 改进
将目录从
openless -all/重命名为openless-all/。同步更新相关引用：
READMECLAUDE.md全仓库 grep 确认旧路径已无残留：
openless -allopenless%20-all修复当前远端基线里的前端构建失败问题：
Settings.tsx中旧调用已改为当前可用的updatePrefs确认根目录已无带空格目录。
兼容
不包含：
对现有用户 / 本地环境 / 构建流程的影响：
openless-all/。openless -all/路径的本地脚本或命令需要同步调整。测试计划
命令：
npm run build结果：通过
证据路径：本地构建输出
命令：
cargo clean && cargo check结果：通过，有既有 warnings
证据路径：本地检查输出
命令：
git diff --check结果：通过
证据路径：本地命令输出
命令：全仓库 grep
openless -all/openless%20-all结果：无残留
证据路径：本地 grep 输出
检查：根目录是否仍存在带空格目录
结果：根目录已无带空格目录
备注
本 PR 主要解决仓库目录命名导致的 Windows GNU/MinGW 构建问题。
Settings.tsx的updatePrefs修改属于顺手修复当前基线构建失败的问题，不改变设置页预期业务行为。Summary by Sourcery
Standardize the repository’s Tauri app directory name to a no-space variant and fix a settings persistence regression in the frontend.
Bug Fixes:
Enhancements:
CI:
Documentation:
Chores: