Skip to content

fix(ui): 提升设置入口可发现性#454

Open
Drswith wants to merge 1 commit into
Open-Less:betafrom
Drswith:codex/fix-settings-sidebar-453
Open

fix(ui): 提升设置入口可发现性#454
Drswith wants to merge 1 commit into
Open-Less:betafrom
Drswith:codex/fix-settings-sidebar-453

Conversation

@Drswith
Copy link
Copy Markdown

@Drswith Drswith commented May 16, 2026

User description

Summary

  • 将设置入口从右下角 footer 移到左侧底部固定区
  • 主导航只保留业务页面,设置仍打开居中设置弹窗
  • 将 BETA 和版本文案放在设置入口下方
  • 统一 FloatingShell.tsx 为 LF 换行

Verification

  • npm run build
  • 浏览器检查左侧底部设置入口、版本文案和设置弹窗

Closes #453


PR Type

Enhancement, Bug fix


Description

  • Move settings into sidebar bottom

  • Keep version and beta labels grouped

  • Hide nav indicator while modal opens

  • Remove footer-only settings icon


Diagram Walkthrough

flowchart LR
  A["Sidebar navigation"] -- "bottom settings entry" --> B["Settings modal"]
  A -- "version and beta metadata" --> C["Sidebar footer info"]
Loading

File Walkthrough

Relevant files
Enhancement
FloatingShell.tsx
Relocate settings entry and footer metadata                           

openless-all/app/src/components/FloatingShell.tsx

  • Adds a labeled settings button at the sidebar bottom.
  • Moves beta tag and version text beneath the entry.
  • Hides the navigation pill while settings is open.
  • Removes the old footer strip and icon component.
+62/-75 

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 16, 2026

PR Reviewer Guide 🔍

(Review updated until commit a46eb71)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

453 - Partially compliant

Compliant requirements:

  • Settings entry moved into the left sidebar bottom area.
  • Settings entry now has a visible text label.
  • Version and beta metadata are grouped below the settings entry.
  • Footer-only settings icon removed.

Non-compliant requirements:

  • None identified from the diff.

Requires further human verification:

  • Whether the new sidebar placement is immediately discoverable in the shipped UI at 1365×768 and larger.
  • Whether the same placement/style is appropriate on macOS if the platform shares this shell.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@appergb
Copy link
Copy Markdown
Collaborator

appergb commented May 16, 2026

你需要提供实际展示图、效果图,并且不混乱,我们才能给你通过 PR。

@Drswith
Copy link
Copy Markdown
Author

Drswith commented May 16, 2026

你需要提供实际展示图、效果图,并且不混乱,我们才能给你通过 PR。

@appergb 你好,这是我的补充信息:
在windows上的运行UI效果,移除了右下底部的版本文案与设置按钮,移动到了左下角,并将原本由于版本文案与设置按钮导致的整体下方空白进行了移除
image

@appergb
Copy link
Copy Markdown
Collaborator

appergb commented May 16, 2026

你可以准备适配一下新版本。如果没有问题的话,我会通过你的这个尝试适配 Beta 版本,在本地构建一下。如果没有问题的话,你的 PR 我待会会通过,因为我更新了这个 PR,它更新了部分 UI 逻辑,我不确定你的历史 UI 逻辑是否适配。

@Drswith Drswith force-pushed the codex/fix-settings-sidebar-453 branch from d811dfd to a46eb71 Compare May 16, 2026 11:24
@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit a46eb71

@Drswith
Copy link
Copy Markdown
Author

Drswith commented May 16, 2026

你可以准备适配一下新版本。如果没有问题的话,我会通过你的这个尝试适配 Beta 版本,在本地构建一下。如果没有问题的话,你的 PR 我待会会通过,因为我更新了这个 PR,它更新了部分 UI 逻辑,我不确定你的历史 UI 逻辑是否适配。

将基线rebase更新到最新beta分支后构建渲染效果如下,无异常

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ui] 提升设置入口可发现性

2 participants