fix(ui): 提升设置入口可发现性#454
Open
Drswith wants to merge 1 commit into
Open
Conversation
PR Reviewer Guide 🔍(Review updated until commit a46eb71)Here are some key observations to aid the review process:
|
Collaborator
|
你需要提供实际展示图、效果图,并且不混乱,我们才能给你通过 PR。 |
Author
@appergb 你好,这是我的补充信息: |
Collaborator
|
你可以准备适配一下新版本。如果没有问题的话,我会通过你的这个尝试适配 Beta 版本,在本地构建一下。如果没有问题的话,你的 PR 我待会会通过,因为我更新了这个 PR,它更新了部分 UI 逻辑,我不确定你的历史 UI 逻辑是否适配。 |
d811dfd to
a46eb71
Compare
|
Persistent review updated to latest commit a46eb71 |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


User description
Summary
Verification
Closes #453
PR Type
Enhancement, Bug fix
Description
Move settings into sidebar bottom
Keep version and beta labels grouped
Hide nav indicator while modal opens
Remove footer-only settings icon
Diagram Walkthrough
File Walkthrough
FloatingShell.tsx
Relocate settings entry and footer metadataopenless-all/app/src/components/FloatingShell.tsx