This repository was archived by the owner on May 15, 2019. It is now read-only.
Reviewing ui INSTALL.md#149
Open
feruiz wants to merge 2 commits intoOpen-Network-Insight:spotfrom
SemantixInfinitePossibilities:ui-documentation-review
Open
Reviewing ui INSTALL.md#149feruiz wants to merge 2 commits intoOpen-Network-Insight:spotfrom SemantixInfinitePossibilities:ui-documentation-review
feruiz wants to merge 2 commits intoOpen-Network-Insight:spotfrom
SemantixInfinitePossibilities:ui-documentation-review
Conversation
Added the paths that worked for me, watchify instructions (necessary for the project) and inserting (nice to have) links.
|
I was thinking, since watchify is not needed for production, what if we add those changes to an extra section, like development requirements or something? Otherwise non developer contributers would install extra packages |
|
@feruiz Any thoughts about this? |
dataminion
reviewed
Dec 29, 2016
dataminion
left a comment
dataminion
left a comment
There was a problem hiding this comment.
I would make the meta comment that perhaps this should exist as a contribution in the wiki
https://help.github.com/articles/adding-and-editing-wiki-pages-locally/
|
what happened with this PR? |
Now we have the step by step for production and development in two distinct blocks.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the paths that worked for me, watchify instructions (necessary
for the project) and inserting (nice to have) links.