Add dashboard loading and empty states#239
Open
jcruz020409-crypto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the dashboard's first-load and empty-result moments.
What changed
I also touched a few nearby dashboard imports and registry bits because they were blocking the page/tests locally while working through this issue.
Checks
npx vitest run components/dashboard/EmptyState.test.tsx components/dashboard/EventListSkeleton.test.tsx components/dashboard/EventFeedTable.test.tsxnpx eslint app/dashboard/DashboardClient.tsx app/layout.tsx components/dashboard/EventFeedTable.tsx components/dashboard/EmptyState.tsx components/dashboard/EventListSkeleton.tsx components/dashboard/EventDetailsModal.tsx lib/hooks/useLiveFeed.ts lib/hooks/useDashboardPrefs.ts lib/translator/registry.ts components/dashboard/EmptyState.test.tsx components/dashboard/EventListSkeleton.test.tsx components/dashboard/EventFeedTable.test.tsxNote: the full repo lint/test/build still runs into unrelated existing blockers in the broader app, so I kept validation focused on the dashboard path touched here.
Closes #228