feat(email-smtp): send HTML message (#385) - #386
Open
mariot wants to merge 1 commit into
Open
Conversation
mariot
added
filigran team
Megafredo
requested changes
Jul 29, 2026
Megafredo
left a comment
Megafredo
left a comment
Member
There was a problem hiding this comment.
It works perfectly!
I'm just making a small suggestion.
| .optional(ContractText(key="bcc", label="Bcc (comma-separated emails)")) | ||
| .mandatory(ContractText(key="subject", label="Subject")) | ||
| .mandatory(ContractTextArea(key="body", label="Body")) | ||
| .mandatory(ContractTextArea(key="body", label="Body (plain text)")) |
Member
There was a problem hiding this comment.
Suggestion: If the user wants to send an email in HTML format only, they are currently required to fill in the Plain text field as well. The simplest solution would be to make the field body optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing Instructions
Related issues
Checklist
Further comments