Blank strings should not be deserialized as JsonNullable.undefined() #125#152
Open
joshuabrandes wants to merge 1 commit into
Open
Blank strings should not be deserialized as JsonNullable.undefined() #125#152joshuabrandes wants to merge 1 commit into
joshuabrandes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #125
@wing328 I hope that works for you. If you want any changes, please let me know.
Summary by cubic
Blank strings now deserialize to
JsonNullable.of(null)(present null) instead ofJsonNullable.undefined()for non-String types. Fixes #125 and aligns behavior with default deserialization.JsonNullableJackson2DeserializerandJsonNullableJackson3Deserializerto let blank strings coerce to null.JsonNullable.of(null)for empty or whitespace strings; missing fields still yieldJsonNullable.undefined().Written for commit 75b6cea. Summary will update on new commits.