Skip to content

Blank strings should not be deserialized as JsonNullable.undefined() #125#152

Open
joshuabrandes wants to merge 1 commit into
OpenAPITools:masterfrom
joshuabrandes:master
Open

Blank strings should not be deserialized as JsonNullable.undefined() #125#152
joshuabrandes wants to merge 1 commit into
OpenAPITools:masterfrom
joshuabrandes:master

Conversation

@joshuabrandes

@joshuabrandes joshuabrandes commented Jun 22, 2026

Copy link
Copy Markdown

addresses #125

@wing328 I hope that works for you. If you want any changes, please let me know.


Summary by cubic

Blank strings now deserialize to JsonNullable.of(null) (present null) instead of JsonNullable.undefined() for non-String types. Fixes #125 and aligns behavior with default deserialization.

  • Bug Fixes
    • Removed the empty-string check from JsonNullableJackson2Deserializer and JsonNullableJackson3Deserializer to let blank strings coerce to null.
    • Updated tests to expect JsonNullable.of(null) for empty or whitespace strings; missing fields still yield JsonNullable.undefined().

Written for commit 75b6cea. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank strings should not be deserialized as JsonNullable.undefined()

1 participant