Skip to content

refactor/removed the Idk from the BankAccountBalance table #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonredfern merged 5 commits into from
May 5, 2025
Merged

refactor/removed the Idk from the BankAccountBalance table #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2487920
refactor/update error logging message for glossary file check for cla…
hongwei1 Apr 29, 2025
0927e3a
refactor/update BankAccountBalance to use KeyedMapper for improved ke…
hongwei1 May 2, 2025
b5df221
refactor/update error logging message for glossary file check for cla…
hongwei1 May 2, 2025
239cf64
refactor/update BankAccountBalance to use KeyedMapper for improved ke…
hongwei1 May 2, 2025
affc86c
Merge remote-tracking branch 'Hongwei/develop' into develop
hongwei1 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion obp-api/src/main/scala/code/api/util/Glossary.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3534,7 +3534,7 @@ object Glossary extends MdcLoggable {
.filter(_.getName.endsWith(".md"))
.toList
} else {
logger.error(s"Do not have any files under glossary path ($glossaryPath), please double check the folder path: $glossaryPath")
logger.error(s"There are no glossary files under the path ($glossaryPath), please double check the folder path: $glossaryPath")
List.empty[File]
}
}
Expand Down
7 changes: 5 additions & 2 deletions obp-api/src/main/scala/code/bankaccountbalance/BankAccountBalance.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@ import net.liftweb.mapper._
import net.liftweb.util.Helpers.tryo


class BankAccountBalance extends BankAccountBalanceTrait with LongKeyedMapper[BankAccountBalance] with CreatedUpdated with IdPK {
class BankAccountBalance extends BankAccountBalanceTrait with KeyedMapper[String, BankAccountBalance]{

override def getSingleton = BankAccountBalance

// Define BalanceId_ as the primary key
override def primaryKeyField = BalanceId_.asInstanceOf[KeyedMetaMapper[String, BankAccountBalance]].primaryKeyField

object BankId_ extends MappedUUID(this)
object AccountId_ extends MappedUUID(this)
object BalanceId_ extends MappedUUID(this)
Expand All @@ -33,4 +36,4 @@ class BankAccountBalance extends BankAccountBalanceTrait with LongKeyedMapper[Ba
override def balanceAmount: BigDecimal = Helper.smallestCurrencyUnitToBigDecimal(BalanceAmount.get, foreignMappedBankAccountCurrency)
}

object BankAccountBalance extends BankAccountBalance with LongKeyedMetaMapper[BankAccountBalance] {}
object BankAccountBalance extends BankAccountBalance with KeyedMetaMapper[String, BankAccountBalance] with CreatedUpdated {}
Loading