Refactor/remove v140, v130,v121 lift#2807
Open
hongwei1 wants to merge 14 commits into
Open
Conversation
…xin from downstream - Rewrite OBPAPI1_4_0: routes=Nil, allResourceDocs aggregates OBPAPI1_3_0+Http4s140 - Drop APIMethods140 import/mixin from OBPAPI5_1_0 and OBPAPI6_0_0 - Add v1_4_0 skip-filter in ResourceDocsAPIMethods.activeResourceDocs - Fix v1_4_0 case in getResourceDocsList to use OBPAPI1_4_0.allResourceDocs - Update JSONFactory1_4_0Test liftDoc reference to OBPAPI1_3_0
…with empty trait All v1.4.0 endpoints are served by Http4s140. The Lift dispatch code is dead.
…echnology check OBPAPI1_4_0.allResourceDocs now uses collectResourceDocs — http4s v1.4.0 docs sort to the front so allResourceDocs.head is http4s. Use OBPAPI1_3_0.allResourceDocs.head (still a Lift doc from APIMethods130) for the technology=liftweb assertion.
…xin from downstream - Rewrite OBPAPI1_3_0: routes=Nil, allResourceDocs aggregates OBPAPI1_2_1+Http4s130 - Drop APIMethods130 import/mixin from OBPAPI5_1_0 and OBPAPI6_0_0 (zero APIMethods remain) - Add v1_3_0 skip-filter in ResourceDocsAPIMethods.activeResourceDocs - Fix v1_3_0 case in getResourceDocsList to use OBPAPI1_3_0.allResourceDocs - Update JSONFactory1_4_0Test liftDoc reference to OBPAPI1_2_1
…with empty trait All v1.3.0 endpoints are served by Http4s130. The Lift dispatch code is dead.
…4_0Test technology check - Rewrite OBPAPI1_2_1: routes=Nil, allResourceDocs = Http4s121.resourceDocs - All versions now fully on http4s — update JSONFactory1_4_0Test to assert TECHNOLOGY_HTTP4S
… with empty trait All v1.2.1 endpoints are served by Http4s121. The Lift dispatch code is dead.
…point rename v2.1.0 STABLE endpoints were renamed during the http4s migration: - addCardsForBank → addCardForBank - answerTransactionRequestChallenge → per-type variants (Free_form, Sepa, Sandbox_tan, Counterparty) FrozenClassTest was comparing the old Lift-era names against the current http4s names and failing both the "increased" and "reduced" scenarios. Run FrozenClassUtil in the test environment to capture the current state.
…efactor/removeV121Lift # Conflicts: # obp-api/src/test/resources/frozen_type_meta_data
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.