Cleanup codeset definitions and references#225
Draft
cjrobbertse-ob wants to merge 62 commits intov4.0.1-draft-1from
Draft
Cleanup codeset definitions and references#225cjrobbertse-ob wants to merge 62 commits intov4.0.1-draft-1from
cjrobbertse-ob wants to merge 62 commits intov4.0.1-draft-1from
Conversation
used twice, now defined once
Reformatted the description for OBInternalConsentStatus1Code in the OpenAPI spec to use a block style and improved readability by separating the link from the main text.
Replaced inline enum definition for ReadRefundAccount with a reference to OBInternalReadRefundAccount1Code schema. This improves reusability and consistency in the OpenAPI specification.
Moved and revised the description for the PeriodType property in the OpenAPI YAML to improve clarity and placement.
Moved and reformatted the description for the PeriodAlignment field in the OpenAPI YAML to improve clarity and maintain consistency with other schema definitions.
Replaced inline Status enum definition with a reference to a new ExternalPaymentTransactionStatus1Code schema. This improves maintainability and reusability by centralizing the status code definitions.
Updated the Status fields in the OpenAPI YAML to use allOf with schema references and added inline descriptions. This improves schema reusability and documentation clarity for payment and transfer status fields.
Deleted the OBAddressTypeCode definition from the OpenAPI YAML file, likely due to deprecation or replacement by OBAddressType2Code.
Replaced inline definition of DebitCreditReportingIndicator with a reference to OBExternalRegulatoryReportingType1Code. Added OBExternalRegulatoryReportingType1Code schema to improve reusability and maintainability.
Deleted the OBVRPStatusReasonCode definition from the OpenAPI YAML file, including its type, enum values, and description. This streamlines the specification and removes an unused or deprecated component.
Replaced inline definition of PaymentContextCode with a reference to OBInternalPaymentContext1Code schema in the OpenAPI spec. This improves maintainability and consistency by centralizing the enum definition.
Reformatted the description for ExternalProxyAccountType1Code in the OpenAPI spec to use YAML block style and improved readability.
Replaced inline definition of DebitCreditReportingIndicator with a reference to OBExternalRegulatoryReportingType1Code and added its schema to components. This improves reusability and consistency in the OpenAPI specification.
Replaced inline PaymentContextCode definition with a $ref to OBInternalPaymentContext1Code schema in the OpenAPI spec. Added OBInternalPaymentContext1Code schema to centralize enum values and improve maintainability.
Replaced inline enum for RequestedSCAExemptionType with a $ref to OBInternalSCAExemptionType1Code schema. This improves maintainability and consistency by centralizing the definition of SCA exemption types.
Replaced inline enum definitions for AuthorisationType with a reference to the OBInternalAuthorisation1Code schema in multiple components. This improves maintainability and consistency by centralizing the enum definition.
Introduced OBInternalReadRefundAccount1Code schema and updated all ReadRefundAccount properties to reference it instead of duplicating type, description, and enum. This improves maintainability and consistency across the OpenAPI specification.
Replaces repeated enum definitions for payment status codes with a reference to the shared ExternalPaymentTransactionStatus1Code schema in the OpenAPI spec. This improves maintainability and ensures consistency across payment-related components.
Replaces the inline definition of AppliedAuthenticationApproach with a reference to the new OBInternalAppliedAuthenticationApproach1Code schema. This change improves schema reusability and consistency by centralizing the enum and description.
Replaced inline enum definition for the Status property with a reference to the OBInternalStatus2Code schema. Added OBInternalStatus2Code schema to centralize the status code definitions and improve maintainability.
Replaces inline Permission property definitions with a reference to the new OBInternalPermissions2Code schema in multiple components. This improves maintainability and consistency by centralizing the enum and description for Open Banking service request types.
Replaces inline enum definition for the Status property in multiple authorisation flow response objects with a reference to the OBInternalStatus2Code schema. This change improves consistency and maintainability of the OpenAPI specification.
Updated the ReadRefundAccount property in the OpenAPI spec to reference the OBInternalReadRefundAccount1Code schema instead of defining enum values inline. This improves maintainability and consistency with other schema references.
Replaces inline AuthorisationType enum definitions with a reference to the OBInternalAuthorisation1Code schema in multiple components. This change improves consistency and maintainability of the OpenAPI specification.
Introduced OBInternalExchangeRateType2Code schema for currency exchange rate types and updated all RateType references to use this new schema via $ref. This change centralizes the enum definition, improves maintainability, and reduces duplication in the OpenAPI specification.
Replaces inline ReadRefundAccount enum definitions with a reference to OBInternalReadRefundAccount1Code schema for consistency and maintainability in the OpenAPI specification.
Replaces direct enum definitions for payment status fields with references to the ExternalPaymentTransactionStatus1Code schema, and updates one instance to define the enum directly. This improves consistency and maintainability of status code definitions.
Updated the Permission property in multiple components to reference OBInternalPermissions2Code instead of defining an inline enum. This change improves schema consistency and reusability.
Updated the Permission property in the OpenAPI spec to reference OBInternalPermissions2Code instead of defining an inline enum. This change promotes schema reuse and consistency.
Replaces inline enum definitions for balance subtypes (BCUR, LCUR) with references to OBExternalBalanceSubType1Code schema in multiple components. This improves schema consistency and reusability.
Introduced OBInternalCardSchemeType1Code schema for card scheme names and updated OBTransactionCardInstrument1 to reference this new schema. This change centralizes the card scheme enumeration and improves maintainability.
Extracted OBInternalCardAuthorisationType1Code as a separate schema and updated OBTransactionCardInstrument1 to reference it. This improves schema reusability and maintainability.
Deleted the OBFrequencyPeriodType enum and its description from the OpenAPI YAML file, likely due to deprecation or redundancy.
Deleted the OBExternalStatementInterestRateType1Code definition from the OpenAPI YAML, including its description, type, example, and enum values.
Deleted the OBAddressTypeCode schema definition from the OpenAPI YAML file, likely as part of a cleanup or deprecation in favor of OBAddressType2Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.