Fix issue #496 #497
Merged
Fix issue #496 #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
had a problem deploying
to
biosimspace-build
GitHub Actions
Failure
Contributor
|
Thanks @lohedges , I've tested this PR and can confirm it fixes the problem. |
lohedges
added a commit
that referenced
this pull request
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #496 by updating Sire
makeCompatibleWithcalls to use the new API, i.e.make_compatible_with. This issue wasn't caught since the calls usetry/except, since they can fail for valid reasons.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]@akalpokas