Remove Masking in Desktop mode #895
Conversation
…ing is done: 1. We must be able to click through annotations. 2. We must be able to click on the palettes. Both will be implemented in other commits.
…inimized. That makes sense, because we cannot do anything, either.
… our help. This is why they are grouped and checkable.
2. In desktop mode, the palette works now. 3. Reverted the commit that removed the code for the manual checking of the icons in the desktop palette as that does not work reliably.
|
I stumbled across your PR while searching for ideas to improve Desktop mode for Wayland. I'm working with KDE, and think I have workarounds for most issues. But there are other problems when using Gnome: Interaction with applications is no longer possible after annotating something. And I thought perhaps your idea would help here. I still have several problems with your PR. The palette does not stay in foreground, at least on KDE. Changing the palette from widget to window also has other implications on Wayland as on X11. The minimized palette always appeared in the center of the screen. With Wayland, you do not have the same control about window positions as on X11. So there is still some work to do. But I think the idea to make the glass pane fully transparent to mouse clicks when the Selector is used is interesting. My question: would you like to help with the adaption to Wayland? The Qt version used is Qt 6. There are no plans to use OpenBoard Qt 5 on Wayland, as all fixes go to Qt 6 now. And what desktop environment are you using? Gnome, KDE, others? |
2 participants
I fixed the problem that you cannot click through the board in desktop mode. For me it works now. But I can only test it on X11 Linux. All this is very platform dependent. Someone must test this on Windows, Wayland Linux and MacOS, with Qt6, in the presenter mode and carefully review my changes. I think, my commit is quite a risky thing. So I don't know if and how you developers prefer to change such things. At some time this thing must be fixed.
Honestly I would recommend you to make the floating palettes not children of the board, before accepting my commit. Because in the current way, there happen too many things, which we don't have fully under control. The floating palettes disappear or become irresponsive together with the board. But you never want that. And you also don't want such a complicated masking mechanism. My solution is that the palette becomes a Qt-Window temporarily, but leaving the parent in. That works currently. But I would not be surprised if in future Qt versions this cheat stops working.