Conversation
Replace references to rainest's private repo with references to the in-tree example-local directory. Rather than asking users to create a fork, ask users to create a new private repository. Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Update images to use latest releases of OpenCHAMI services. Remove custom pre-release builds. Use minor version tags for most services. Use an explicit version tag for power-control because its package doesn't have minor version tags currently. Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Update the ochami CLI tool install instructions to use the v0.7.0 release from upstream. This version has the additional features needed for the PCS endpoints used in the demo. Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Remove caveat re unexplained issue. We can't reproduce this no more! The alternate check mechanism remains valid and is still in the documentation, but the copy's been simplified. Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Clarify the branch and directory structure needs of the private repo. Fix an unintended pasted URL. Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Collaborator
Author
|
Also using this as an opportunity to add branch protection now that this has more than one contributor. Ditto auto-merge. @cjh1 on additional review the BMC address should be okay on the IP example, rather than using a port-foward, since we patch the Service to a LoadBalancer. There were some cases where I had used verbatim IPs, and those will vary per environment. Storing the IP in ennvars should usually allow us to ignore that variance. The browser UI for Argo's an exception, but I don't wanna bother with fake DNS yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address most of the issues raised in #6 in preparation for a wider end user audience.
Replace references to my private repository with the in-tree example.
Use updated image versions. Remove custom builds. Features we need have been merged.
Update the
ochamiCLI tool version and use the upstream package. Since theochamitool now has OpenCHAMI/ochami#47 and OpenCHAMI/ochami#51 merged, we can use an official build, and don't need some of the PCS hacks to deal with with things static discovery didn't populate.Remove the caveat about bits of the CLI not working for transition checks. Unclear what broke here. Chris couldn't reproduce it.
Clean up some documentation to add clarifying statements and remove some assumptions I had made re my personal copies.