feat(discovery): support multiple SMD groups during static discovery

[synackd]

Closes #32

Changes

• Add groups directive to static discovery specification to specify a list of groups to add a node to during discovery.
  • These groups will get created in SMD.
• Deprecate group directive in static discovery specification.
  • Add deprecation warnings for group and remove it from examples
  • If used with groups, the group specified is merged with the groups list
  • group will be removed in a future release of ochami
• Refactor deduplication maps to be defined outside of node loop (feat: add fake power actions #47 (comment))

Testing

Write a nodes.yaml that includes combinations of groups and group and attempt static discovery via ochami discover static -f yaml -d @nodes.yaml.

• groups only:

  nodes:
  ...
   - name: node01
     groups:
       - group1
       - group2
     ...

  Result: node01 should be added to groups group1 and group2, which get added to SMD.

• group only:

  nodes:
  ...
   - name: node01
     group: group1
     ...

  Result: node01 should be added to group group1, which gets added to SMD. The ochami command should display a warning that group was used for node01 and that it is deprecated.

• group and groups:

  CASE 1: group is also a member of groups

  nodes:
  ...
   - name: node01
     group: group1
     groups:
       - group1
       - group2
     ...

  Result: node01 should be added to groups group1 and group2, which get added to SMD. The ochami command should display a warning that group was used for node01 and that it is deprecated.

  CASE 2: group is not a member of groups

  nodes:
  ...
   - name: node01
     group: group3
     groups:
       - group1
       - group2
     ...

  Result: node01 should be added to groups group1, group2, and group3, which get added to SMD. The ochami command should display a warning that group was used for node01 and that it is deprecated.

Notes

• If using SMD < v2.19.0, use --discovery-version 1 so that the creation of EthernetInterfaces for type Node works during discovery.
  • Needs fix(discover): send EthernetInterfaces on version 1 instead of 2 #52 to be merged.

[davidallendj]

Looks like everything works and the deprecated message is shown properly from my testing.

[davidallendj]

LGTM

Looks like it needs to be rebased as well.

[synackd]

Rebased and checks are passing. Hitting merge.