fix(cmd/smd): correct smd component add example#61
Open
pirese wants to merge 1 commit intoOpenCHAMI:mainfrom
Open
fix(cmd/smd): correct smd component add example#61pirese wants to merge 1 commit intoOpenCHAMI:mainfrom
pirese wants to merge 1 commit intoOpenCHAMI:mainfrom
Conversation
Fixed an error in the example provided for adding an smd component from a json payload; "Enabled" field should be a boolean instead of a string or json marshalling fails. ERR lib.go:472 > unable to read payload data or file error="unable to unmarshal bytes into value: json: cannot unmarshal string into Go struct field Component.Components.Enabled of type bool Signed-off-by: Ellis Pires <ellis.pires@gmail.com>
shunr-hpe
approved these changes
Oct 22, 2025
Collaborator
|
Good catch! Could you check if this needs to be fixed elsewhere? Best to fix it all in one go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
Fixed an error in the example provided for adding an smd component from a json payload; "Enabled" field should be a boolean instead of a string or json marshalling fails.
ERR lib.go:472 > unable to read payload data or file error="unable to unmarshal bytes into value: json: cannot unmarshal string into Go struct field Component.Components.Enabled of type bool
Fixes #(issue)
Type of Change
For more info, see Contributing Guidelines.