Added pkg/schemas/jsonschemas to gitignore#76
Merged
Conversation
shunr-hpe
requested review from
alexlovelltroy,
bmcdonald3 and
davidallendj
Collaborator
davidallendj
left a comment
davidallendj
left a comment
There was a problem hiding this comment.
I believe the pkg/schemas/jsonschemas directory is generated from the test right? I don't think it's necessary to add generated data to the.gitignore and we should probably remove it in the test itself instead.
shunr-hpe
force-pushed
the
gitignore-jsonschemas
branch
from
3fb706e to
0b1a09b
Compare
Signed-off-by: Shane Unruh <shane.unruh@hpe.com>
shunr-hpe
force-pushed
the
gitignore-jsonschemas
branch
from
0b1a09b to
e95e320
Compare
Collaborator
Author
|
@davidallendj Thanks for the suggestion. I changed the test to remove the directory, and removed my changes to gitignore and Makefile. My goal is to not have a dirty |
bmcdonald3
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the unit test to remove pkg/schemas/jsonschemas when done.