Add SerialConsole and CommandShell to RF#81
Conversation
Signed-off-by: Chris Harris <cjh@lbl.gov>
|
There may be a more smd way to add this configuration, but i wanted to get a stake in the ground ... feedback welcome. |
|
Curious about backwards compatibility. Will we need to recompile other services/clients to be aware of the structs changing? |
My understanding is that they are backward compatible. To convince myself of this I ran the PCS test suite which use SMD discovery ( but doesn't have emulators with the new config ) with these changes and everything works. @shunr-hpe Are there other SMD tests we should run to confirm this? |
|
I don't know of specific tests to verify this. In general most clients of SMD should be able to handle new fields being added, by ignoring them. After this is submitted it makes sense to update the servers/clients that use those go structs. |
|
@shunr-hpe If you are happy can we merge this, I don't have the power. |
Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
This PR is a proof of concept of adding support to include RF console information in component endpoints.
Fixes #(issue)
Type of Change
For more info, see Contributing Guidelines.