Skip to content

Add SerialConsole and CommandShell to RF#81

Merged
shunr-hpe merged 1 commit intoOpenCHAMI:mainfrom
cjh1:rf-console
Jan 21, 2026
Merged

Add SerialConsole and CommandShell to RF#81
shunr-hpe merged 1 commit intoOpenCHAMI:mainfrom
cjh1:rf-console

Conversation

@cjh1
Copy link
Member

@cjh1 cjh1 commented Nov 7, 2025

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

This PR is a proof of concept of adding support to include RF console information in component endpoints.

Fixes #(issue)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

Signed-off-by: Chris Harris <cjh@lbl.gov>
@cjh1
Copy link
Member Author

cjh1 commented Nov 7, 2025

There may be a more smd way to add this configuration, but i wanted to get a stake in the ground ... feedback welcome.

@cjh1 cjh1 marked this pull request as ready for review January 12, 2026 19:23
@alexlovelltroy
Copy link
Member

Curious about backwards compatibility. Will we need to recompile other services/clients to be aware of the structs changing?

@cjh1
Copy link
Member Author

cjh1 commented Jan 14, 2026

Curious about backwards compatibility. Will we need to recompile other services/clients to be aware of the structs changing?

My understanding is that they are backward compatible. To convince myself of this I ran the PCS test suite which use SMD discovery ( but doesn't have emulators with the new config ) with these changes and everything works. @shunr-hpe Are there other SMD tests we should run to confirm this?

@shunr-hpe
Copy link
Collaborator

I don't know of specific tests to verify this.

In general most clients of SMD should be able to handle new fields being added, by ignoring them.

After this is submitted it makes sense to update the servers/clients that use those go structs.

@cjh1
Copy link
Member Author

cjh1 commented Jan 21, 2026

@shunr-hpe If you are happy can we merge this, I don't have the power.

@shunr-hpe shunr-hpe merged commit 63e15b2 into OpenCHAMI:main Jan 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants