Skip to content

Allow a custom HTTP client to be used with ServiceReservation#83

Merged
davidallendj merged 1 commit intoOpenCHAMI:mainfrom
cjh1:with-client
Jan 20, 2026
Merged

Allow a custom HTTP client to be used with ServiceReservation#83
davidallendj merged 1 commit intoOpenCHAMI:mainfrom
cjh1:with-client

Conversation

@cjh1
Copy link
Member

@cjh1 cjh1 commented Jan 15, 2026

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
  • Each new/modified source file has SPDX copyright and license headers
  • Any non-commentable files include a <filename>.license sidecar
  • All referenced licenses are present in the LICENSES/ directory

Description

PCS uses the ServiceReservation interface to make reservations, we need to be able to initialize it with custom HTTP client which has an OAuth2 transport enabled.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

Signed-off-by: Chris Harris <cjh@lbl.gov>
Copy link
Collaborator

@davidallendj davidallendj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidallendj davidallendj merged commit ddda559 into OpenCHAMI:main Jan 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants