Skip to content

chore(connectors): fix connector slug conflicts and rename directories (#6600)#6691

Open
jabesq wants to merge 3 commits into
masterfrom
issue/6600-connector-identity-uniqueness
Open

chore(connectors): fix connector slug conflicts and rename directories (#6600)#6691
jabesq wants to merge 3 commits into
masterfrom
issue/6600-connector-identity-uniqueness

Conversation

@jabesq

@jabesq jabesq commented Jun 10, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Rename external-import/lastinfosecexternal-import/lastinfosec-feed: the manifest already declared slug: lastinfosec-feed but the folder basename was lastinfosec, causing a mismatch. Updates Dockerfile, entrypoint, docker-compose, and README.
  • Rename internal-enrichment/lastinfosecinternal-enrichment/lastinfosec-enrichment and update its slug from lastinfosec to lastinfosec-enrichment: the old slug collided with the external-import connector's slug. Both folder and manifest now reflect the unique identity.
  • Change internal-enrichment/eset-enrichment slug from eset to eset-enrichment: avoids a too-generic slug that could conflict with future connectors.

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Several connectors had slugs or folder names that were duplicated or mismatched across the repository (e.g. two connectors sharing the slug lastinfosec, a folder basename that differed from its declared slug). These are fixed here to establish a clean baseline.

Copilot AI review requested due to automatic review settings June 10, 2026 13:14
@jabesq jabesq added the filigran team Item from the Filigran team. label Jun 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves connector identity conflicts by aligning connector folder basenames, manifest slug values, and container_image names so they’re unique and consistent across the repository (notably for the two LastInfoSec connectors and ESET enrichment).

Changes:

  • Renamed the external-import LastInfoSec connector directory to external-import/lastinfosec-feed and updated its Docker/runtime assets and manifest to match the declared slug/image.
  • Renamed the internal-enrichment LastInfoSec connector to internal-enrichment/lastinfosec-enrichment, updated its manifest slug/image, and added refreshed deployment/docs assets.
  • Updated internal-enrichment/eset-enrichment manifest slug to eset-enrichment to avoid slug collisions.

Reviewed changes

Copilot reviewed 7 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal-enrichment/lastinfosec-enrichment/src/requirements.txt Adds/pins runtime dependencies for the internal-enrichment LastInfoSec connector.
internal-enrichment/lastinfosec-enrichment/src/lastinfosec.py Internal-enrichment connector implementation (enrichment callback + API call).
internal-enrichment/lastinfosec-enrichment/src/config.yml.sample Sample YAML configuration for the internal-enrichment connector.
internal-enrichment/lastinfosec-enrichment/README.md Documentation for installing/configuring/deploying the internal-enrichment connector.
internal-enrichment/lastinfosec-enrichment/LASTINFOSEC_LOGO_NOIR.png Adds a LastInfoSec logo asset in the connector directory.
internal-enrichment/lastinfosec-enrichment/entrypoint.sh Container entrypoint adjusted for the renamed internal-enrichment directory.
internal-enrichment/lastinfosec-enrichment/Dockerfile Docker build updated for the renamed internal-enrichment directory.
internal-enrichment/lastinfosec-enrichment/docker-compose.yml Compose example updated for new service/image naming.
internal-enrichment/lastinfosec-enrichment/.dockerignore Docker ignore rules for config and cache files.
internal-enrichment/lastinfosec-enrichment/metadata/connector_manifest.json Updates slug/source_code/logo path/container_image to match the renamed internal-enrichment connector.
internal-enrichment/eset-enrichment/metadata/connector_manifest.json Updates slug to eset-enrichment to prevent collisions.
external-import/lastinfosec-feed/src/requirements.txt Adds/pins runtime dependencies for the external-import LastInfoSec feed connector.
external-import/lastinfosec-feed/src/lastinfosec.py External-import connector implementation (polling + work creation + bundle push).
external-import/lastinfosec-feed/src/config.yml.sample Sample YAML configuration for the feed connector.
external-import/lastinfosec-feed/README.md Updates docs to reflect the lastinfosec-feed naming (image/build/compose examples).
external-import/lastinfosec-feed/LASTINFOSEC_LOGO_NOIR.png Adds a LastInfoSec logo asset in the connector directory.
external-import/lastinfosec-feed/entrypoint.sh Updates runtime working directory for renamed external-import connector.
external-import/lastinfosec-feed/Dockerfile Updates copy/workdir paths for renamed external-import connector.
external-import/lastinfosec-feed/docker-compose.yml Updates service and image naming for lastinfosec-feed.
external-import/lastinfosec-feed/.dockerignore Docker ignore rules for config and cache files.
external-import/lastinfosec-feed/metadata/logo.png Connector logo used by the manifest.
external-import/lastinfosec-feed/metadata/connector_manifest.json Updates logo/source_code/container_image paths to match renamed external-import connector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(all): resolve conflict between connectors with similar names or slugs

3 participants