chore(connectors): fix connector slug conflicts and rename directories (#6600)#6691
Open
jabesq wants to merge 3 commits into
Open
chore(connectors): fix connector slug conflicts and rename directories (#6600)#6691jabesq wants to merge 3 commits into
jabesq wants to merge 3 commits into
Conversation
…nfosec-feed This align connector name with its slug
…nt/lastinfosec-enrichment
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves connector identity conflicts by aligning connector folder basenames, manifest slug values, and container_image names so they’re unique and consistent across the repository (notably for the two LastInfoSec connectors and ESET enrichment).
Changes:
- Renamed the external-import LastInfoSec connector directory to
external-import/lastinfosec-feedand updated its Docker/runtime assets and manifest to match the declared slug/image. - Renamed the internal-enrichment LastInfoSec connector to
internal-enrichment/lastinfosec-enrichment, updated its manifest slug/image, and added refreshed deployment/docs assets. - Updated
internal-enrichment/eset-enrichmentmanifest slug toeset-enrichmentto avoid slug collisions.
Reviewed changes
Copilot reviewed 7 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal-enrichment/lastinfosec-enrichment/src/requirements.txt | Adds/pins runtime dependencies for the internal-enrichment LastInfoSec connector. |
| internal-enrichment/lastinfosec-enrichment/src/lastinfosec.py | Internal-enrichment connector implementation (enrichment callback + API call). |
| internal-enrichment/lastinfosec-enrichment/src/config.yml.sample | Sample YAML configuration for the internal-enrichment connector. |
| internal-enrichment/lastinfosec-enrichment/README.md | Documentation for installing/configuring/deploying the internal-enrichment connector. |
| internal-enrichment/lastinfosec-enrichment/LASTINFOSEC_LOGO_NOIR.png | Adds a LastInfoSec logo asset in the connector directory. |
| internal-enrichment/lastinfosec-enrichment/entrypoint.sh | Container entrypoint adjusted for the renamed internal-enrichment directory. |
| internal-enrichment/lastinfosec-enrichment/Dockerfile | Docker build updated for the renamed internal-enrichment directory. |
| internal-enrichment/lastinfosec-enrichment/docker-compose.yml | Compose example updated for new service/image naming. |
| internal-enrichment/lastinfosec-enrichment/.dockerignore | Docker ignore rules for config and cache files. |
| internal-enrichment/lastinfosec-enrichment/metadata/connector_manifest.json | Updates slug/source_code/logo path/container_image to match the renamed internal-enrichment connector. |
| internal-enrichment/eset-enrichment/metadata/connector_manifest.json | Updates slug to eset-enrichment to prevent collisions. |
| external-import/lastinfosec-feed/src/requirements.txt | Adds/pins runtime dependencies for the external-import LastInfoSec feed connector. |
| external-import/lastinfosec-feed/src/lastinfosec.py | External-import connector implementation (polling + work creation + bundle push). |
| external-import/lastinfosec-feed/src/config.yml.sample | Sample YAML configuration for the feed connector. |
| external-import/lastinfosec-feed/README.md | Updates docs to reflect the lastinfosec-feed naming (image/build/compose examples). |
| external-import/lastinfosec-feed/LASTINFOSEC_LOGO_NOIR.png | Adds a LastInfoSec logo asset in the connector directory. |
| external-import/lastinfosec-feed/entrypoint.sh | Updates runtime working directory for renamed external-import connector. |
| external-import/lastinfosec-feed/Dockerfile | Updates copy/workdir paths for renamed external-import connector. |
| external-import/lastinfosec-feed/docker-compose.yml | Updates service and image naming for lastinfosec-feed. |
| external-import/lastinfosec-feed/.dockerignore | Docker ignore rules for config and cache files. |
| external-import/lastinfosec-feed/metadata/logo.png | Connector logo used by the manifest. |
| external-import/lastinfosec-feed/metadata/connector_manifest.json | Updates logo/source_code/container_image paths to match renamed external-import connector. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
external-import/lastinfosec→external-import/lastinfosec-feed: the manifest already declaredslug: lastinfosec-feedbut the folder basename waslastinfosec, causing a mismatch. Updates Dockerfile, entrypoint, docker-compose, and README.internal-enrichment/lastinfosec→internal-enrichment/lastinfosec-enrichmentand update its slug fromlastinfosectolastinfosec-enrichment: the old slug collided with the external-import connector's slug. Both folder and manifest now reflect the unique identity.internal-enrichment/eset-enrichmentslug fromesettoeset-enrichment: avoids a too-generic slug that could conflict with future connectors.Related issues
Checklist
Further comments
Several connectors had slugs or folder names that were duplicated or mismatched across the repository (e.g. two connectors sharing the slug
lastinfosec, a folder basename that differed from its declared slug). These are fixed here to establish a clean baseline.