Skip to content

ci: add workflow to check connector identity uniqueness (#6599)#6692

Open
jabesq wants to merge 1 commit into
masterfrom
ci/6599-connector-identity-uniqueness
Open

ci: add workflow to check connector identity uniqueness (#6599)#6692
jabesq wants to merge 1 commit into
masterfrom
ci/6599-connector-identity-uniqueness

Conversation

@jabesq

@jabesq jabesq commented Jun 10, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Add .github/scripts/check_connector_identity_uniqueness.py — a Python script that scans every connector directory across all five connector-type roots and asserts that three identity fields are unique repository-wide: the connector folder basename (used by CI to derive Docker image names), slug, and container_image from connector_manifest.json.
  • Add .github/workflows/check-connector-identity-uniqueness.yml — a GitHub Actions workflow that runs the script automatically on every push that touches a connector_manifest.json file, also available via workflow_dispatch. Runs with minimal permissions (contents: read) and pins checkout to a full commit SHA.

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

The script is intentionally stdlib-only so it runs directly with system Python 3 on ubuntu-latest without any install step. The workflow is path-scoped to only trigger on manifest changes, with a concurrency group to cancel redundant back-to-back runs. The folder-basename check is separate from manifest field checks because folder names are not declared in manifests but are implicitly used by the CI image-naming convention.

Copilot AI review requested due to automatic review settings June 10, 2026 13:39
@jabesq jabesq added the filigran team Item from the Filigran team. label Jun 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a lightweight repository guardrail to prevent connector identity collisions that would break CI/Docker image naming by enforcing repository-wide uniqueness across connector directories and key manifest identity fields.

Changes:

  • Introduces a stdlib-only Python script to scan all connector roots and detect duplicates for folder basename, slug, and container_image.
  • Adds a GitHub Actions workflow to run the check on pushes affecting connector manifests (and manually via workflow_dispatch).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/check-connector-identity-uniqueness.yml New workflow to run the uniqueness check when connector manifests change.
.github/scripts/check_connector_identity_uniqueness.py New stdlib-only script that scans connector directories/manifests and reports identity duplicates.

Comment thread .github/scripts/check_connector_identity_uniqueness.py Outdated
Comment thread .github/workflows/check-connector-identity-uniqueness.yml
@jabesq jabesq force-pushed the ci/6599-connector-identity-uniqueness branch from d450e59 to 5c74756 Compare June 10, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: add check to ensure connector folder name is unique

3 participants