ci: add workflow to check connector identity uniqueness (#6599)#6692
Open
jabesq wants to merge 1 commit into
Open
ci: add workflow to check connector identity uniqueness (#6599)#6692jabesq wants to merge 1 commit into
jabesq wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a lightweight repository guardrail to prevent connector identity collisions that would break CI/Docker image naming by enforcing repository-wide uniqueness across connector directories and key manifest identity fields.
Changes:
- Introduces a stdlib-only Python script to scan all connector roots and detect duplicates for folder basename,
slug, andcontainer_image. - Adds a GitHub Actions workflow to run the check on pushes affecting connector manifests (and manually via
workflow_dispatch).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/check-connector-identity-uniqueness.yml | New workflow to run the uniqueness check when connector manifests change. |
| .github/scripts/check_connector_identity_uniqueness.py | New stdlib-only script that scans connector directories/manifests and reports identity duplicates. |
d450e59 to
5c74756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
.github/scripts/check_connector_identity_uniqueness.py— a Python script that scans every connector directory across all five connector-type roots and asserts that three identity fields are unique repository-wide: the connector folder basename (used by CI to derive Docker image names),slug, andcontainer_imagefromconnector_manifest.json..github/workflows/check-connector-identity-uniqueness.yml— a GitHub Actions workflow that runs the script automatically on every push that touches aconnector_manifest.jsonfile, also available viaworkflow_dispatch. Runs with minimal permissions (contents: read) and pins checkout to a full commit SHA.Related issues
Checklist
Further comments
The script is intentionally stdlib-only so it runs directly with system Python 3 on
ubuntu-latestwithout any install step. The workflow is path-scoped to only trigger on manifest changes, with aconcurrencygroup to cancel redundant back-to-back runs. The folder-basename check is separate from manifest field checks because folder names are not declared in manifests but are implicitly used by the CI image-naming convention.