fix: resolve competition place deduction crashes in purchasePlaces#364
Open
SiRipo92 wants to merge 28 commits intoOpenClassrooms-Student-Center:masterfrom
Open
fix: resolve competition place deduction crashes in purchasePlaces#364SiRipo92 wants to merge 28 commits intoOpenClassrooms-Student-Center:masterfrom
SiRipo92 wants to merge 28 commits intoOpenClassrooms-Student-Center:masterfrom
Conversation
…t, used condition to set flash message, set 200 status code and stay on index.html
… without crashing
fix: handle unknown email gracefully in showSummary
Fix/competition places not deducted
refactor: PEP8 fixes in show_summary - snake_case and spacing
refactor: PEP8 fixes in purchasePlaces - snake_case in function name
Refactoring to utilize pytest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Problem
purchasePlaces() crashed with IndexError 500 when competition or club
names from the form did not match the database. [0] was called on an
empty list with no error handling, making the function unreachable in
error scenarios.
Root Cause
Two instances of [0] list indexing assumed a match would always be found:
competition = [c for c in competitions if c['name'] == ...][0]
club = [c for c in clubs if c['name'] == ...][0]
Fix
redirect to welcome.html keeping the user logged in
Tests