Improvement : check if competition is sold out#366
Open
Tit-Co wants to merge 12 commits intoOpenClassrooms-Student-Center:masterfrom
Open
Improvement : check if competition is sold out#366Tit-Co wants to merge 12 commits intoOpenClassrooms-Student-Center:masterfrom
Tit-Co wants to merge 12 commits intoOpenClassrooms-Student-Center:masterfrom
Conversation
…, add message in index template
…ase places with not enough points, update unit tests
…ld not be able to book more than 12 places per competition, update unit tests
…is typed while booking
…ate not reflected, update unit tests with mocks
…d not be able to book more than 12 places per competition, update tests
…aces in past competitions should not be possible, add two more unit tests for that bug fix
…ould not be able to book more than places available, update unit tests
…, add one more unit test for that improvement, update unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improvement
server.pybookroute.welcometemplate with an error message if the condition fails.Template
Unit tests