Skip to content

fix(settings): improve keybind binding UX (OPEN-54) #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zortos293 merged 2 commits into from
Apr 14, 2026
Merged

fix(settings): improve keybind binding UX (OPEN-54) #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
846e022
fix(settings): easier keybind capture, conflicts, and recording shortcut
cursoragent Apr 11, 2026
bc57556
merge origin/dev into cursor/fix-settings-keybinds-45a3
cursoragent Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions opennow-stable/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions opennow-stable/src/renderer/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ const resolutionOptions = getResolutionsByAspectRatio("16:9");

function getAppStyle(posterSizeScale: number): CSSProperties {
return {
["--game-poster-scale" as "--game-poster-scale"]: String(posterSizeScale),
};
"--game-poster-scale": String(posterSizeScale),
} as CSSProperties;
}
const SESSION_READY_POLL_INTERVAL_MS = 2000;
const SESSION_AD_POLL_INTERVAL_MS = 30000;
Expand Down Expand Up @@ -810,6 +810,7 @@ export function App(): JSX.Element {
enableL4S: false,
enableCloudGsync: false,
discordRichPresence: false,
posterSizeScale: 1,
});
const [settingsLoaded, setSettingsLoaded] = useState(false);
const [codecResults, setCodecResults] = useState<CodecTestResult[] | null>(() => loadStoredCodecResults());
Expand Down Expand Up @@ -3235,6 +3236,7 @@ export function App(): JSX.Element {
toggleStats: formatShortcutForDisplay(settings.shortcutToggleStats, isMac),
togglePointerLock: formatShortcutForDisplay(settings.shortcutTogglePointerLock, isMac),
stopStream: formatShortcutForDisplay(settings.shortcutStopStream, isMac),
toggleAntiAfk: shortcuts.toggleAntiAfk.canonical,
toggleMicrophone: formatShortcutForDisplay(settings.shortcutToggleMicrophone, isMac),
screenshot: shortcuts.screenshot.canonical,
recording: shortcuts.recording.canonical,
Expand Down
Loading
Loading