Add session fullscreen shortcut and auto-toggle on connection#307
Merged
Add session fullscreen shortcut and auto-toggle on connection#307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable fullscreen shortcut that works only while in an active session and fixes auto-fullscreen to enter when connecting rather than only on pointer lock.
Settings & Persistence:
shortcutToggleFullscreento shared and main settings interfaces with defaultF10.DEFAULT_SHORTCUTSin renderer and defaults inSettingsPage.Renderer Behavior:
setSessionFullscreen/toggleSessionFullscreenhelpers that unify HTML fullscreen requests with native window fullscreen sync (viawindow.openNow.setFullscreen). Used by pointer-lock auto-fullscreen, main-process events, manual toggle, and the new auto-connect effect.toggleFullscreento the global keydown handler, gated tostreamStatus === "connecting" || "streaming"with prevent/stop/stopImmediatePropagation like other session shortcuts.connectingorstreaming, guarded byautoFullscreenRequestedRefto avoid repeated calls.toggleFullscreenintoStreamView.shortcutsprop and added a "Full screen" hint to the on-screen shortcuts overlay.Settings Page:
toggleFullscreenInput,toggleFullscreenError) with effect sync.handleShortcutBlur,applyShortcutCapture,handleShortcutPaste,handleShortcutCaptureKeyDown,areShortcutsDefault,handleResetShortcuts.autoFullScreenhint to: "Automatically enter fullscreen when connecting to or starting a session."Main Process:
autoFullScreensettings-change handler that immediately toggled native fullscreen; fullscreen is now driven by renderer session logic.