Draft
Conversation
Reusing `_killStatsOnPlayerKillLock`, renamed to `_killStatsAndAchievementLock`
* Moved money related properties and method to a new `Wallet` class. * Removed `Money` static class and moved its content to a new `WalletHelper` static class. * Replaced various usage to prevent unsafe reads (read the full value at once). * Fixed unsafe writes. * Optimized money to money parts conversion.
Was removed by 7f44429 * Removed duplicate code between `GamePlayer.TryPickUpMoney` and `Group.TryPickUpMoney`, moved to `Wallet`. * Moved `ApplyGuildDues` from `WalletHelper` to `Wallet` (now only used by `Wallet`). * Improved `Wallet` argument validation.
bm01
force-pushed
the
fix/concurrent-reward-on-kill
branch
from
71f70b3 to
352b58f
Compare
bm01
force-pushed
the
fix/concurrent-reward-on-kill
branch
from
352b58f to
8dd3477
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More to come (RPs, BPs, XP).