Make default boot state user configurable#30
Merged
jerrysxie merged 4 commits intoOpenDevicePartnership:mainfrom Oct 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable default boot state mechanism, allowing users to customize the initial state when no state is loaded from the journal. The change replaces the hardcoded default boot state with a trait-based approach.
- Introduces a
DefaultBootStatetrait with a customizabledefault_state()method - Updates the
Boardtrait to requireConfigtypes to implementDefaultBootState - Refactors the boot initialization logic to use the trait-provided default state
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libs/ec-slimloader/src/lib.rs | Defines the DefaultBootState trait and updates Board::Config to require it; refactors boot state initialization to use the trait method |
| libs/ec-slimloader-imxrt/src/lib.rs | Adds DefaultBootState trait bound to the Board implementation for IMXRT platforms |
| examples/rt685s/bootloader/src/main.rs | Implements DefaultBootState for the example configuration using default trait implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jerrysxie
requested changes
Oct 20, 2025
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
/approve |
jerrysxie
approved these changes
Oct 21, 2025
gjpmsft
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
BootStatePolicytrait to the bootloader library, allowing bootloader applications to do the following:The trait is defined for the
Configstructure and not theBoardstructure since this policies are application specific and not platform dependent.