Add minimal button tests#306
Open
felipebalbi wants to merge 1 commit intoOpenDevicePartnership:mainfrom
Open
Conversation
felipebalbi
added
cargo vet
Contributor
Author
|
Still need to integrate |
Cargo Vet Audit Passed
|
This commit adds a minimal set of tests for the button logic. Notice that this is, indeed, a breaking a change and coordination with dependent crates is required.
felipebalbi
requested review from
JamesHuard,
RobertZ2011,
asasine,
jerrysxie,
madeleyneVaca and
tullom
as code owners
RobertZ2011
requested changes
May 21, 2025
| integrator: u8, | ||
| threshold: u8, | ||
| sample_interval: Duration, | ||
| sample_interval: u32, |
Contributor
There was a problem hiding this comment.
Can yo update the name to sample_interval_ms?
|
|
||
| #[test] | ||
| fn test_last_update_state_change() { | ||
| // Press, active high |
Contributor
There was a problem hiding this comment.
Isn't this active low because that's the default for Debouncer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a minimal set of tests for the button logic. Notice that this is, indeed, a breaking a change and coordination with dependent crates is required.