Fix CFU breaking changes, update battery-service device to use Mutex, and update examples#386
Conversation
6f00f26 to
56f07c6
Compare
|
The changes themselves look good to me but the commit structure is a bit odd IMO. I'd suggest the first commit be renamed to something more descriptive than "Test", and it also fails to build (all commits should be able to build independently). The second commit could maybe be split into several others as it seems to handle a few different things but that's more of a nit. |
and fix breaking changes in CFU
@kurtjd Good catch, this PR was originally intended to be a test PR but it evolved into a full blown change. Renamed the commits to be more descriptive. The first commit is all cargo updates and CFU changes, second commit is battery changes. The commits will be squashed anyways so this separation of commits is just for ease of review. |
Ah yeah, forgot that we squash commits, I apologize. But looks good! |
Thank you to @magravel for fixing the changes in embedded-cfu-protocol. This PR includes the same .rs changes in #341.
Cargo.toml