Open
Conversation
tullom
force-pushed
the
cfu-service-refactor
branch
from
6015bd5 to
128333b
Compare
kurtjd
approved these changes
Feb 5, 2026
RobertZ2011
requested changes
Feb 5, 2026
RobertZ2011
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor CFU service and move embedded_services::cfu module to cfu_service
As a consequence of moving CFU data structures out of embedded-service, type-c service needs to take a dependency on cfu-service. Chatted with @RobertZ2011 offline and verified that the eventual goal is to move CFU out of type-c service by abstracting out a firmware update trait that the type-c service will use and the CFU service will impl.