Skip to content

Remove deprecated eSPI memory map#707

Merged
williampMSFT merged 3 commits intoOpenDevicePartnership:v0.2.0from
williampMSFT:user/williamp/remove-mmap
Feb 6, 2026
Merged

Remove deprecated eSPI memory map#707
williampMSFT merged 3 commits intoOpenDevicePartnership:v0.2.0from
williampMSFT:user/williamp/remove-mmap

Conversation

@williampMSFT
Copy link
Contributor

@williampMSFT williampMSFT commented Feb 5, 2026

The eSPI memory map is no longer in use, so this change removes it to simplify. As part of this, also remove examples that were intended to exercise the now-removed functionality.

Resolves #692

The eSPI memory map is no longer in use, so this change removes it to simplify.
As part of this, also remove examples that were intended to exercise the now-removed functionality.
Copilot AI review requested due to automatic review settings February 5, 2026 22:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the deprecated eSPI memory map infrastructure and associated example code that exercised it. The memory map was previously used to expose EC (Embedded Controller) data structures to the host via eSPI, but this functionality is no longer needed.

Changes:

  • Removed entire ec_type module from embedded-service, including structures, messages, and code generation scripts for the memory map
  • Deleted three example binaries that demonstrated the removed memory map functionality
  • Simplified espi-service to remove memory map buffer parameter and related initialization code
  • Added battery-service-messages dependency to example projects as a replacement for the removed message types

Reviewed changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
examples/std/src/bin/battery.rs Deleted example that demonstrated battery service integration with eSPI memory map
examples/std/Cargo.toml Added battery-service-messages dependency
examples/std/Cargo.lock Updated lock file with new dependency
examples/rt633/src/bin/espi_battery.rs Deleted hardware example using eSPI memory map with real battery hardware
examples/rt633/src/bin/espi.rs Deleted basic eSPI memory map example with mock battery service
examples/rt633/Cargo.toml Added battery-service-messages dependency with defmt feature
examples/rt633/Cargo.lock Updated lock file with new dependency
espi-service/src/task.rs Removed memory_map_buffer parameter and initialization logic
espi-service/src/espi_service.rs Removed _ec_memory field from Service struct and ec_memory parameter from new()
embedded-service/src/lib.rs Removed ec_type module export
embedded-service/src/ec_type/structure.rs Deleted EC memory structure definitions
embedded-service/src/ec_type/mod.rs Deleted module containing memory map conversion functions and tests
embedded-service/src/ec_type/message.rs Deleted message type enums for Battery, Thermal, Capabilities, etc.
embedded-service/src/ec_type/generator/ec_memory_map.yaml Deleted YAML schema for memory map generation
embedded-service/src/ec_type/generator/ec-memory-generator.py Deleted Python code generator for memory map structures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@tullom tullom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aligned with this change, but just want an approval from @jerrysxie before this goes in.

@williampMSFT williampMSFT merged commit 02017d7 into OpenDevicePartnership:v0.2.0 Feb 6, 2026
15 checks passed
@williampMSFT
Copy link
Contributor Author

I'm aligned with this change, but just want an approval from @jerrysxie before this goes in.

Whoops, sorry, just saw this after I hit the merge button - fwiw I did chat with Jerry offline before sending this out and he said he's onboard with removing the examples that were leveraging the memory map, so I think we're good here, but I'll mention it in the standup tomorrow and we can revert if there are concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants