Skip to content

Supports the titlebar DMF attribute#2618

Closed
PowerfulBacon wants to merge 2 commits into
OpenDreamProject:masterfrom
PowerfulBacon:titlebar-parameter-and-options-in-browse
Closed

Supports the titlebar DMF attribute#2618
PowerfulBacon wants to merge 2 commits into
OpenDreamProject:masterfrom
PowerfulBacon:titlebar-parameter-and-options-in-browse

Conversation

@PowerfulBacon

@PowerfulBacon PowerfulBacon commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

This PR implements the ability to create a borderless window in the Clyde window engine (Requires space-wizards/RobustToolbox#6618), and implements the titlebar property, which hides the title bars when set to 0.

Because most TGUI windows set this property through browse(), I have also implemented support for passing options through to browse as right now only the size option is being handled.

These TGUI windows cannot yet be moved, as there is no support for moving windows from code in the Clyde engine, and I suspect that there may be some trouble getting that in if there are security concerns about having arbitrarily moving windows.

image image

@boring-cyborg boring-cyborg Bot added Client Involves the OpenDream client Runtime Involves the OpenDream server/runtime labels Jun 5, 2026
@github-actions github-actions Bot added the size/L label Jun 5, 2026
@PowerfulBacon PowerfulBacon marked this pull request as draft June 5, 2026 21:15
Comment thread OpenDreamRuntime/DreamConnection.cs
@PowerfulBacon

Copy link
Copy Markdown
Contributor Author

I could probably split this up so that the titlebar support which depends on a robust toolbox PR can come later.

@ike709

ike709 commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

These TGUI windows cannot yet be moved, as there is no support for moving windows from code in the Clyde engine, and I suspect that there may be some trouble getting that in if there are security concerns about having arbitrarily moving windows.

When things calm down we can shoot PJB a message about the security concerns.

based PR, the titlebars have been annoying me for a while

@PowerfulBacon

PowerfulBacon commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Im worried that there will be concerns about the ability to set the position of windows and remove the borders which will be needed for fancy TGUI. Im hoping that since they can be closed if misbehaving by just closing all from the task bar then it won't be a huge issue.

For now ill atomize out the browse() handling options and then deal with things needing RT changes when the PRs can be merged

@amylizzle

Copy link
Copy Markdown
Collaborator

is this cross platform? can you test in on windows, wayland and X?

@PowerfulBacon

Copy link
Copy Markdown
Contributor Author

I believe it will be cross-platform since its a standard SDL call, but I'm trying to find a good way of testing this

@PowerfulBacon PowerfulBacon changed the title Supports options in browse() and titlebar support. Supports the titlebar DMF attribute Jun 7, 2026
@PowerfulBacon

Copy link
Copy Markdown
Contributor Author

I'll let the robust toolbox PR progress before re-opening this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client Involves the OpenDream client Runtime Involves the OpenDream server/runtime size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants