Fix correctness bugs from the full codebase review#88

Merged

matt-pharr merged 16 commits into

developfrom

bugfix/review-findings

Jul 13, 2026

Commits on Jul 10, 2026

spectral: wrap delta_phi and pick an alias-safe 2-point pair

matt-pharr
and
claude
committed
spectral: pin one signed-n convention across all estimators

matt-pharr
and
claude
committed
fetch: merge remote pulls into an existing shot file instead of clobbering

matt-pharr
and
claude
committed
qs_fit: de-normalize fit_signal by the same sigma that built the RHS

matt-pharr
and
claude
committed
qs_fit: restore OMFIT's 1e3 inversion cutoff as the fit_cond default

matt-pharr
and
claude
committed
fetch: fetch KSTAR plasma tree_signals; guard pointname alias collisions

matt-pharr
and
claude
committed
fetch: stop caching transport failures as missing channels (#63)

matt-pharr
and
claude
committed
spectral: scale spectrogram cross-power to csd's one-sided density

matt-pharr
and
claude
committed
service: refresh clears theta cache; QS bands via contract; NaN -> null

matt-pharr
and
claude
committed
gui: honest error/staleness handling, retryable fetches, device-snap fixes

matt-pharr
and
claude
committed
mode_number: let the n-map band follow the requested f_max (#85)

matt-pharr
and
claude
committed
hygiene: un-skew test_nodes fixture, harden CI, declare pexpect, fix stale docs

matt-pharr
and
claude
committed
docs: add a 'Running the tests' section to CLAUDE.md

matt-pharr
and
claude
committed
test: cover the fetch orchestration, gaussian bases, and prep branches

matt-pharr
and
claude
committed
ci: enforce a 75% coverage floor on the pytest job

matt-pharr
and
claude
committed
tests: fix ruff lint errors failing CI's 3.12 leg

matt-pharr
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix correctness bugs from the full codebase review#88

Fix correctness bugs from the full codebase review#88
matt-pharr merged 16 commits into
developfrom
bugfix/review-findings

Commits on Jul 10, 2026

spectral: wrap delta_phi and pick an alias-safe 2-point pair

spectral: pin one signed-n convention across all estimators

fetch: merge remote pulls into an existing shot file instead of clobbering

qs_fit: de-normalize fit_signal by the same sigma that built the RHS

qs_fit: restore OMFIT's 1e3 inversion cutoff as the fit_cond default

fetch: fetch KSTAR plasma tree_signals; guard pointname alias collisions

fetch: stop caching transport failures as missing channels (#63)

spectral: scale spectrogram cross-power to csd's one-sided density

service: refresh clears theta cache; QS bands via contract; NaN -> null

gui: honest error/staleness handling, retryable fetches, device-snap fixes

mode_number: let the n-map band follow the requested f_max (#85)

hygiene: un-skew test_nodes fixture, harden CI, declare pexpect, fix stale docs

docs: add a 'Running the tests' section to CLAUDE.md

test: cover the fetch orchestration, gaussian bases, and prep branches

ci: enforce a 75% coverage floor on the pytest job

tests: fix ruff lint errors failing CI's 3.12 leg