Improve Solr connection error handling and improve HTML sanitization#61
Merged
jguo144 merged 2 commits intoMay 11, 2026
Merged
Conversation
[2.10] Fix for Solr connection errors leaking details
helpers: strip tags with bleach only
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
nolanpruett
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves error handling for Solr connection failures and improve HTML sanitization in markdown rendering.
Changes
Search error handling
SolrConnectionErrorexception type for connection-specific failuresPackageSearchQueryand raise appropriate exceptionHTML sanitization
RE_MD_HTML_TAGSpattern withbleach_clean(strip=True)markdown_extract()andrender_markdown()Upstream Commits