chore(deps): update black and mypy#315
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| show_error_context = true | ||
| strict_equality = false | ||
| python_version = 3.9 | ||
| python_version = "3.10" |
There was a problem hiding this comment.
Bumping mypy's python_version to "3.10" while the package still declares requires-python = ">=3.9" (and keeps the Python :: 3.9 classifier) means mypy will now type-check against 3.10 semantics for all runs — including the 3.9 CI job that pins mypy == 1.19.*. As a result, uses of 3.10-only stdlib/typing features or syntax that would break at runtime on 3.9 will no longer be flagged. If 3.9 is still a supported target, consider leaving this at 3.9 (or dropping 3.9 support altogether); otherwise the 3.9 leg of the test matrix is being type-checked under the wrong assumptions.
Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
| # extension module). | ||
| - name: cargo deny check licenses, bans, sources | ||
| run: cargo deny --manifest-path rust-bindings/Cargo.toml check --config deny.toml licenses bans sources | ||
| run: cargo deny --manifest-path rust-bindings/Cargo.toml --config deny.toml check licenses bans sources |
There was a problem hiding this comment.
The old commands used the documented cargo-deny form where --config and --exclude-dev are options of the check subcommand (note the previous advisories command placed --exclude-dev after the advisories positional, confirming these are subcommand-level flags, while only --manifest-path is global).
This PR moves both --config deny.toml and --exclude-dev to before the check subcommand. If the installed cargo-deny still treats these as check-subcommand options, clap will reject them in the global position with an "unexpected argument" error and break the CI job. Since cargo install cargo-deny --locked pulls the latest release, please confirm the installed version accepts --config/--exclude-dev before the subcommand; if not, keep them after check (e.g. check --config deny.toml advisories --exclude-dev).
3 participants
Updating deps:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.