Skip to content

chore(deps): upgrade mypy and pytest with Python 3.9 version markers #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jericht merged 2 commits into from
Jul 3, 2026
Merged

chore(deps): upgrade mypy and pytest with Python 3.9 version markers #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13f626c
chore(deps): upgrade mypy and pytest with Python 3.9 version markers
jericht Jul 2, 2026
fae5496
fix(test): add None check for logger.extra to satisfy mypy 2.x
jericht Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ disallow_incomplete_defs = false
disallow_untyped_calls = false
show_error_context = true
strict_equality = false
python_version = 3.9
warn_redundant_casts = true

@github-actions github-actions Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing python_version = 3.9 means mypy now targets whatever interpreter it runs under (Python 3.10+ per the new mypy == 2.1.* split) instead of the minimum supported version. As a result type-checking will no longer catch code that uses 3.10+-only syntax/APIs but must still run on 3.9 (which is still in requires-python = ">=3.9" and the classifiers). Consider keeping the target pinned to the floor, e.g. python_version = "3.9" (quoted, since mypy 2.x is stricter about the value type), so 3.9 incompatibilities are still flagged.

warn_unused_configs = true
warn_unused_ignores = false
Expand Down
6 changes: 4 additions & 2 deletions requirements-testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
coverage[toml] == 7.*
coverage-conditional-plugin == 0.9.*
pytest == 8.4.*
pytest == 8.4.*; python_version == "3.9"
pytest == 9.1.*; python_version >= "3.10"
pytest-cov == 7.1.*
pytest-timeout == 2.4.*
pytest-xdist == 3.8.*
black == 25.*
ruff == 0.15.*
psutil >= 5.9,< 7.3
mypy == 1.19.*
mypy == 1.19.*; python_version == "3.9"
mypy == 2.1.*; python_version >= "3.10"
1 change: 1 addition & 0 deletions test/openjd/sessions_v0/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def test_initiaize_basic(self) -> None:
assert session._job_parameter_values == job_params
assert session._job_parameter_values is not job_params
assert isinstance(session._logger, LoggerAdapter)
assert session._logger.extra is not None
assert "session_id" in session._logger.extra
assert session._logger.extra["session_id"] == session_id
assert session._log_filter in LOG.filters
Expand Down
Loading