Skip to content

fix: poll through CANCELING state to deliver terminal callback #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwiebe merged 1 commit into from
Jul 21, 2026
Merged

fix: poll through CANCELING state to deliver terminal callback #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/openjd/sessions/_v1/_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def observable(s: ActionStatus) -> tuple:
while True:
state = self._rust_session.state
status = self._rust_session.action_status
if state == SessionState.RUNNING:
if state in (SessionState.RUNNING, SessionState.CANCELING):

@godobyte godobyte Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated end-to-end via the AWS Deadline Cloud worker agent e2e suite (cancel scenarios all passing; full Linux suite 48/49 with the one failure unrelated to this change).

Were there any test failing due to the lack of this change?

@seant-aws seant-aws Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, all the cancel tests in the E2E when hardcoding to use the rust runtime were not working due to this miss

if status is not None and self._callback:
if not reported_running:
# Defensive: the synchronous initial callback
Expand All @@ -201,7 +201,7 @@ def observable(s: ActionStatus) -> tuple:
self._callback(self._session_id, status)
time.sleep(0.05)
continue
# Not RUNNING anymore — action is done.
# Not RUNNING/CANCELING anymore — action is done.
# If we never saw RUNNING (e.g. Rust finished before we got here),
# still report the RUNNING transition first, so the agent state
# machine sees Start → End in order.
Expand Down
Loading