fix: allow Task.File.* in <StepScript>.let, matching Env.File.* in environments#152
Merged
mwiebe merged 1 commit intoJul 17, 2026
Conversation
… in environments The Let Binding Scope Summary granted Env.File.* to <EnvironmentScript>.let but omitted Task.File.* from <StepScript>.let. The rationale for the Env case — embedded file paths are determined before let evaluation — applies identically to step scripts, and implementations already validate and evaluate Task.File.* in step-script let bindings (OpenJobDescription/openjd-rs#260). - Add Task.File.* to the <StepScript>.let scope row and generalize the embedded-file note to cover both contexts (2023-09 Template Schemas 3.6.2) - Align RFC 0005's ScriptTemplate let description, which granted embedded file symbols to environment scripts via example but never stated the step-script side - Exercise Task.File.* in the 3.6 let-host-context-symbols validation fixture (its header comment already claimed this coverage) and add a 7.3 runtime test mirroring the existing Env.File one Signed-off-by: Mark <399551+mwiebe@users.noreply.github.com>
epmog
approved these changes
Jul 17, 2026
leongdl
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Templates can define embedded files — small scripts or config
files that the worker writes to disk before running an action.
Env.File.<name>and
Task.File.<name>are the symbols that tell you where such a file willland. With the
EXPRextension,letbindings let you name a computed valueonce and reuse it across the script.
The spec's Let Binding Scope Summary (Template Schemas §3.6.2) says an
environment script's
letbindings may referenceEnv.File.*, because thefile's path is decided before the bindings run — only its content is
evaluated later. That exact reasoning applies to step scripts and
Task.File.*too, but the<StepScript>.letrow never granted it. Whilefixing evaluation ordering in OpenJobDescription/openjd-rs#260 we found that
implementations already accept
Task.File.*there — the spec table was justinconsistent between the two contexts.
The change
Grant
Task.File.*in the<StepScript>.letscope row andgeneralize the accompanying note to cover both contexts; state the same grant
explicitly in RFC 0005 (which previously only implied the environment side via
an example); and back it with conformance tests — the §3.6 validation fixture
now actually exercises
Task.File.*inlet(its header comment alreadyclaimed to), plus a new runtime test mirroring the existing
Env.Fileone.Verification
Full
2023-09/EXPRconformance suite passes (350/350) againstopenjd-rs built with #260. A pre-#260 build fails the new runtime test,
confirming it guards the fixed behavior.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.