Adding OpenKh.Tools.Kh2FontImageEditor#847
Draft
kenjiuno wants to merge 11 commits intoOpenKH:masterfrom
Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
This could be an error on my part (it's been a long time now since I've patched, tested, and used the PS2 version of the game for modifications and testing OpenKH tools), however upon patching the game with an edited fontimage.bar file using this tool, this is the end result. I will include the fontimage in question as well. I have yet to test using the OpenKH mod manager method, though I am unsure that would change the result. This methodology of testing I have done is using the legacy, far outdated patching method. |
Collaborator
Collaborator
Author
|
Hi I have rewritten some of this editor. Could you please re-test again. |
Contributor
|
Bumping this for testing. |
Collaborator
|
I will test this soon! |
Contributor
|
Bumping for testing again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


About
Editor of both
fontimage.barandfontinfo.bar.Initial
FontJapanese
Spacing editor
Unresolved issues
Alpha value ranging of
IconThe one big problem is that color palette of
Iconimage.This is an
Indexed8image so we can edit the palette too.But the alpha channel (Ps2 alpha) of the palette has irregular rule that we had not before.
0 to 128 is mapped to 0 to 255 (0.0 to 1.0) in PC.
129 to 255 is what for? This is for brighter alpha color blending (1.0 to 2.0).
We need good sense and good idea and valid data format to support this overkill usage of alpha channel of color palette for import and export purpose.
Untested for non FontJapanese