Explictly mark cost for cloned vehicles as vehicle purchase costs #3618
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| static uint32_t cloneVehicle(EntityId head, uint8_t flags) | ||
| { | ||
| setExpenditureType(ExpenditureType::VehiclePurchases); |
Contributor
There was a problem hiding this comment.
Have you checked this works? I was just thinking the other day this wouldn't be super simple to do as this uses nested functions and the nested function might adjust the expenditure type.
Member
Author
There was a problem hiding this comment.
It seems to work fine, yeah:
Screen.Recording.2026-01-19.at.22.06.21.mp4
Contributor
There was a problem hiding this comment.
That is not a sufficient test you would need to either clone a ship, aircraft or a train in express mode. Those are the types that will change the expenditure type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.