Make the thunderx2 zdot kernel compatible with LLVM21 in Windows on Arm#5575
Conversation
| " cmp "J", xzr \n" | ||
| " beq 3f //dot_kernel_F1 \n" | ||
|
|
||
| "// .align 5 \n" |
There was a problem hiding this comment.
Merge my PR (#5566) to avoid regressing quality on non-windows platforms? With #if !(defined(__clang__) && defined(OS_WINDOWS))
There was a problem hiding this comment.
certainly - this is just the second part required for making the change do anything useful for WoA when compiled on device, where LLVM (and CMake) is currently the only option.
the huge diff due to CRLF line endings is also spurious and temporary - but I really had to prioritize unrelated work when you brought it up
There was a problem hiding this comment.
Not actually the only option: I am using clang from WSL, so that I can use all the familiar make tools and linux environment on-device, with native support for .exe files running natively (via binfmt magic). Only oddness is needing to set CROSS=1 to compile, then CROSS=0 to run the tests.
I can share the details of the setup if you like.
| #ifndef _MSC_VER | ||
| " .align 5 \n" | ||
| #endif |
There was a problem hiding this comment.
The MSC compiler versions (aka cl) don't even support asm, so it cannot even parse this file. It is a bit confusing to have this macro being used to mean defined __clang__ && defined _WIN32 here
2 participants
No description provided.