Add update_config handler and recreate services#41
Merged
Conversation
Introduce a new update_config flow: HandleConfigUpdate stops services, updates env vars (via envVariables and files.UpdateEnvFile), and recreates containers with the updated compose using DockerManager.RecreateDockerServices. RecreateDockerServices runs docker-compose up --no-build --force-recreate against a temp compose file with timeout and proper cleanup. Added envVariables helper and unit tests to validate its behavior, and wired the new action into OTAProcess. Includes progress/error reporting and improved logging/error handling during the config update path.
shicaih
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new update_config flow: HandleConfigUpdate stops services, updates env vars (via envVariables and files.UpdateEnvFile), and recreates containers with the updated compose using DockerManager.RecreateDockerServices. RecreateDockerServices runs docker-compose up --no-build --force-recreate against a temp compose file with timeout and proper cleanup. Added envVariables helper and unit tests to validate its behavior, and wired the new action into OTAProcess. Includes progress/error reporting and improved logging/error handling during the config update path.