Skip to content

Move example DAEs to examples/ and drop the broken Influenza example#75

Merged
JKRT merged 1 commit into
OpenModelica:masterfrom
SVAGEN26:remove-influenza-move-examples
Jun 19, 2026
Merged

Move example DAEs to examples/ and drop the broken Influenza example#75
JKRT merged 1 commit into
OpenModelica:masterfrom
SVAGEN26:remove-influenza-move-examples

Conversation

@SVAGEN26

Copy link
Copy Markdown
Contributor

Relocates the hand-built example DAE_LIST fixtures from test/ExampleDAE/ to a conventional root-level examples/ directory, and removes the Influenza example.

Why remove Influenza: it fails MTK structural_simplify with StateSelection.ExtraVariablesSystemException (over-determined system) — verified on Julia 1.12 / Windows. It was exported but unused by the test suite, so dropping it is safe. This also fixes a dangling export (the file defined influenza_DAE but the module exported influenca_DAE).

What's here:

  • git mv test/ExampleDAE -> examples/ (the fixtures remain the backend test contract; test/runtests.jl now includes them from ../examples/).
  • Repointed both include sites in runtests.jl (test-relative and repo-root-relative).
  • examples/README.md with a model table, and examples/simulate_examples.jl, a runnable translate -> simulateModel demo.

Verification: with the examples relocated, HelloWorld, LotkaVolterra and VanDerPol all translate + simulate to retcode = Success via the MTK backend on Julia 1.12 (Windows).

🤖 Generated with Claude Code

- git mv test/ExampleDAE -> examples/ (conventional root-level location);
  these hand-built DAE_LIST fixtures stay the backend test contract, now
  also serving as runnable examples.
- Remove the Influenza example: it fails MTK structural_simplify with
  StateSelection.ExtraVariablesSystemException (over-determined system) and
  was exported but unused by the test suite.
- Fix dangling export: the file defined `influenza_DAE` but the module
  exported `influenca_DAE`.
- Repoint the two test includes to the new examples/ location.
- Add examples/README.md (model table) and examples/simulate_examples.jl,
  a runnable translate->simulate demo. HelloWorld / LotkaVolterra / VanDerPol
  verified to reach retcode=Success via the MTK backend on Julia 1.12 (Windows).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@JKRT JKRT merged commit f2d1285 into OpenModelica:master Jun 19, 2026
3 checks passed
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (48757b0) to head (9e7826e).
⚠️ Report is 27 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   24.78%   21.67%   -3.11%     
==========================================
  Files          28       43      +15     
  Lines        3430    20615   +17185     
==========================================
+ Hits          850     4468    +3618     
- Misses       2580    16147   +13567     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants