Fixes to workflow and precompilation#77
Open
JKRT wants to merge 12 commits into
Open
Conversation
…s Spice3 in_c) Algorithmic Modelica function bodies kept a record used as a whole value as a bare symbol, so a record copy / call argument / return / field-index referenced an undeclared symbol (e.g. `in_c` in the Spice3 MOSFET functions), failing the in-backend structural_simplify build. Scalarise every record use onto the flattened `<base>_<field>` symbols (the naming flattenRecordInput already emits): - whole-record copy lhs := rhs -> per-field assignments - record call argument -> splat into its flat field symbols - record-valued call assignment -> scatter the flat-tuple return - record cref indexed by a constant -> the kth flat field symbol All four Spice3 examples (Inverter, Nor, Nand, FourInverters) now build via the in-backend structural_simplify path (previously they fell back). Detection is fully structural (cref/type pattern-matching, no string parsing); helpers carry strict argument types and signature docstrings. LRT green (289 pass / 0 fail / 6 broken) with this change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Three test-only fixes for type mismatches against production:
- mock stringToSimVarHT used Tuple{Integer, SimVar}; SIM_CODE requires
Tuple{Int, SimVar} (backendTestMocks.jl, simCodeTraverseTests.jl)
- mkWhenEq passed nothing for the attr field added to WHEN_EQUATION;
use EQ_ATTR_DEFAULT_UNKNOWN (runtests.jl)
Suite: 228/228 pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 24.78% 21.40% -3.38%
==========================================
Files 28 44 +16
Lines 3430 21213 +17783
==========================================
+ Hits 850 4541 +3691
- Misses 2580 16672 +14092 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to fix the slow precompilation issue on windows