Fix/docs submodule#90
Merged
Merged
Conversation
The docs job runs `Pkg.develop(path = OMFrontend.jl)`, which makes Pkg inspect the package git tree. The `test/3rdParty/Buildings` submodule is checked out with submodules:false and is not needed for documentation, but its dangling reference makes LibGit2 fail with "cannot get submodules without a working tree". Remove the reference so develop sees a clean tree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Coverage is redundant across OSes. Gate --code-coverage, processcoverage, and the Codecov upload behind a matrix `coverage` flag set only on ubuntu-latest, so Windows and macOS run tests without the coverage overhead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Developing the siblings first re-resolved the docs environment while OMFrontend was still a registry/git dependency, so Pkg cloned OMFrontend (and OMParser/ImmutableList) from GitHub and failed on the test submodule. Develop OMFrontend in the same call so it is never materialized from git. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
===========================================
+ Coverage 20.40% 30.98% +10.57%
===========================================
Files 166 181 +15
Lines 60213 61390 +1177
===========================================
+ Hits 12288 19022 +6734
+ Misses 47925 42368 -5557 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI fixes + integration of exporter code for JSON/ADT and adjustment to error handling when dealing with replaceable components