Don't crash on missing configured libraries#50
Merged
Conversation
Deleting a Modelica library directory that was still listed in the `modelica.libraries` setting caused the language server to throw an unhandled error during `initialize`, failing the LSP handshake and leaving the server in a restart loop. `Analyzer.loadLibrary` now checks that the path exists and contains a `package.mo` before loading, returning `false` (with a debug log) instead of throwing when it doesn't. Server initialization wraps each workspace and configured-library load so a single bad entry no longer aborts startup. When a configured library is skipped, the server raises a VS Code warning notification telling the user to fix or remove the entry from the `modelica.libraries` setting. Adds regression tests for skipping non-existent library and workspace paths. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #49.
Rational
Deleting a Modelica library directory that was still listed in the
modelica.librariessetting caused the language server to throw an unhandled error duringinitialize, failing the LSP handshake and leaving the server in a restart loop.Changes
Analyzer.loadLibrarynow checks that the path exists and contains apackage.mobefore loading, returningfalse(with a debug log) instead of throwing when it doesn't. Server initialization wraps each workspace and configured-library load so a single bad entry no longer aborts startup. When a configured library is skipped, the server raises a VS Code warning notification telling the user to fix or remove the entry from themodelica.librariessetting.Adds regression tests for skipping non-existent library and workspace paths.