Make e2e tests deterministic instead of sleeping#53
Merged
Conversation
The language server initializes and parses documents asynchronously, so waiting a fixed amount of time after activation was racy: slow machines (CI) could still see empty provider results while fast machines wasted seconds. - Add executeProviderUntilResult() helper that polls a provider command until it returns a non-empty result (or times out) - Use it in the gotoDeclaration, mslLibrary, and symbolinformation tests - Drop the fixed sleep(5000) from activate() and document that the server is not guaranteed ready when it returns - Pin the VS Code test version to 'stable' and cache the download in CI for reproducible, faster runs - Ignore *.tsbuildinfo Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language server initializes and parses documents asynchronously, so waiting a fixed amount of time after activation was racy: slow machines (CI) could still see empty provider results while fast machines wasted seconds.