feat: implement action-oriented list view for consignment workflow #257#265
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience in the Trader App's consignment workflow by introducing a simplified, action-oriented list view. This new interface streamlines task management, making it easier for traders to identify and act on critical steps, while still retaining the detailed graph visualization for those who need it. The changes aim to improve usability and efficiency by presenting information in a more digestible format. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new action-oriented list view for the consignment workflow, which is a great enhancement for user experience. The changes include several new React components and updates to the main consignment detail screen. My review focuses on improving the implementation of these new components, addressing a critical issue with dynamic Tailwind CSS classes that could break production builds, enhancing cross-browser compatibility for UI elements, and refactoring some parts of the code for better clarity and correctness.
portals/apps/trader-app/src/components/WorkflowViewer/ActionCard.tsx
Outdated
Show resolved
Hide resolved
portals/apps/trader-app/src/components/WorkflowViewer/ActionCard.tsx
Outdated
Show resolved
Hide resolved
portals/apps/trader-app/src/components/WorkflowViewer/ActionCard.tsx
Outdated
Show resolved
Hide resolved
|
@mushrafmim Rebase this before merge |
71d14fe to
fc7f9e5
Compare
Summary
This PR introduces an action-oriented Action List View for the consignment workflow in the Trader App. The goal is to provide a simplified, user-friendly interface that prioritizes immediate tasks (Ready/In-Progress) while grouping upcoming and completed steps into organized, collapsible sections. This reduces cognitive load for traders compared to the full graph visualization.
Type of Change
Changes Made
ActionListView: Main container that groups workflow nodes into "Action Required", "Upcoming Tasks", and "Process History".ActionCard: An individual task card displaying the task name, type icon, description, and status badges, with primary actions (Start/View).CollapsibleSection: A reusable component to hide/show secondary workflow groups.ConsignmentDetailScreento include aviewModetoggle (listvsgraph).custom-scrollbarutility classes inindex.cssfor a cleaner scroll experience in the list view.Testing
Checklist
Related Issues
Closes #257
Screenshots/Demo
Screen.Recording.2026-03-19.at.09.09.34.mov
Additional Notes
The implementation follows the progressive disclosure strategy:
READYandIN_PROGRESStasks are always expanded.