chore: remove category field from material_type_enum#114
chore: remove category field from material_type_enum#114CZDanol merged 1 commit intoOpenPrintTag:mainfrom
Conversation
|
Hello and thanks for your contribution :) Hmm, there's nothing wrong with your PR, but I don't mind approving this, just thinking whether it would be better to remove the field altogether now. |
That is actually even better for me, as I was just about to make an issue about how currently the I'll make a follow up removing it. |
|
LGTM, thanks :) Feel free to merge |
|
I can't merge? I don't have write permission to the repo 😄 |
|
Oh, sorry :D |
This change makes so the casing for the category value is consistent between
material_type_enumandmain_fields. Also okay with changing it somain_fieldsis uppercase instead but I think this makes the most sense.